/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fix typo in comment #31364

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@bdarnell bdarnell

@tschottdorf tschottdorf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@benesch @cockroach-teamcity @bdarnell
@benesch
Member

benesch commented Oct 15, 2018

Release note: None
@benesch
storage: fix typo in comment 
Release note: None
Verified
This commit was signed with a verified signature.
@benesch benesch Nikhil Benesch
GPG key ID: F7386C5DEADABA7F Learn about signing commits
Loading status checks…
9a41001

@benesch benesch requested a review from tschottdorf Oct 15, 2018

@benesch benesch requested a review from cockroachdb/core-prs as a code owner Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable
@benesch

This comment has been minimized.

Show comment
Hide comment
@benesch

benesch Oct 15, 2018

Member

Thanks!

bors r=bdarnell
Member

benesch commented Oct 15, 2018

Thanks!

bors r=bdarnell

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @tschottdorf @benesch
Merge #31344 #31364 
31344: status: fix a comment r=petermattis,vilterp a=tschottdorf

Passing `true` here gives results for each NIC. If `false` were passed,
things would be summed up and a single result returned.

Release note: None

31364: storage: fix typo in comment r=bdarnell a=benesch

Release note: None

Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Loading status checks…
0c150f9
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build succeeded

craig bot commented Oct 15, 2018

Build succeeded

@craig craig bot merged commit 9a41001 into cockroachdb:master Oct 15, 2018
2 of 3 checks passed

2 of 3 checks passed

GitHub CI (Cockroach) TeamCity build failed
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment