/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: build: check out submodules before yarn install #31365

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@cockroachdb/build-prs build-prs

@couchand couchand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@benesch @cockroach-teamcity @tschottdorf
@benesch
Member

benesch commented Oct 15, 2018

Backport 1/1 commits from #30993.

/cc @cockroachdb/release

yarn install requires the yarn-vendor submodule to be available.
This was missed when we started vendoring our Yarn dependencies in
PR #27035.

Fix #30619.

Release note: None
@benesch
build: check out submodules before yarn install 
`yarn install` requires the yarn-vendor submodule to be available.
This was missed when we started vendoring our Yarn dependencies in
PR #27035.

Fix #30619.

Release note: None
Verified
This commit was signed with a verified signature.
@benesch benesch Nikhil Benesch
GPG key ID: F7386C5DEADABA7F Learn about signing commits
Loading status checks…
b649df3

@benesch benesch requested a review from couchand Oct 15, 2018

@benesch benesch requested a review from cockroachdb/build-prs as a code owner Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable
@tschottdorf

This comment has been minimized.

Show comment
Hide comment
@tschottdorf

tschottdorf Oct 15, 2018

Member

LGTM
Member

tschottdorf commented Oct 15, 2018

LGTM

@benesch benesch merged commit f29847d into cockroachdb:release-2.1 Oct 15, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@benesch benesch deleted the benesch:backport2.1-30993 branch Oct 15, 2018

@benesch

This comment has been minimized.

Show comment
Hide comment
@benesch

benesch Oct 15, 2018

Member

Thanks!
Member

benesch commented Oct 15, 2018

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment