/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: ui: Have the range debug page correctly handle missing lease times #31367

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@couchand couchand

@vilterp vilterp

Assignees
No one assigned
Labels
None yet
Projects
  
Sprint: Done in Web UI
Milestone
  2.1
3 participants
@BramGruneir @cockroach-teamcity @couchand
@BramGruneir
Member

BramGruneir commented Oct 15, 2018

Backport 1/1 commits from #31362.

/cc @cockroachdb/release

Before this change, the value was always assumed to be not-null and it was null
would crash. It will now correctly handled the missing value and display a
no timestamp warning.

Fixes #31260.

Release note (bug fix): The range debug page will now correctly handle cases in
which there is no lease start or expiration time.

screen shot 2018-10-15 at 10 35 07
@BramGruneir
ui: Have the range debug page correctly handle missing lease times 
Before this change, the value was always assumed to be not-null and it was null
would crash. It will now correctly handled the missing value and display a
`no timestamp` warning.

Fixes #31260.

Release note (bug fix): The range debug page will now correctly handle cases in
which there is no lease start or expiration time.
Loading status checks…
7d8e24b

@BramGruneir BramGruneir added this to the 2.1 milestone Oct 15, 2018

@BramGruneir BramGruneir requested a review from vilterp Oct 15, 2018

@BramGruneir BramGruneir requested a review from cockroachdb/admin-ui-prs as a code owner Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable

@BramGruneir BramGruneir merged commit b379f28 into cockroachdb:release-2.1 Oct 15, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@BramGruneir BramGruneir added this to Sprint: Done in Web UI via automation Oct 15, 2018

@BramGruneir BramGruneir deleted the BramGruneir:backport2.1-31362 branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment