/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: tag the slack message with the cloud #31376

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@benesch benesch

@tschottdorf tschottdorf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@petermattis @cockroach-teamcity @benesch
@petermattis
Contributor

petermattis commented Oct 15, 2018

For example, [AWS] or [GCE].

Release note: None
@petermattis
roachtest: tag the slack message with the cloud 
For example, `[AWS]` or `[GCE]`.

Release note: None
Loading status checks…
b08d662
@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable

@petermattis petermattis requested review from benesch and tschottdorf Oct 15, 2018

Show resolved Hide resolved pkg/cmd/roachtest/slack.go
@petermattis

This comment has been minimized.

Show comment
Hide comment
@petermattis

petermattis Oct 15, 2018

Contributor

bors r=benesch
Contributor

petermattis commented Oct 15, 2018

bors r=benesch

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @RaduBerinde @petermattis
Merge #31363 #31376 
31363: distsqlrun: fix Sampler test flake r=RaduBerinde a=RaduBerinde

The Sampler test verifies that the sampling is uniform by running it
many times and checking the frequencies. The probability of failure
decreases exponentially with `numRuns`.

The fix increases the number of runs to 5000 but to avoid slowing down
the test, we modify it to check every 200 runs (and exit early).

Fixes #31293.

Release note: None

31376: roachtest: tag the slack message with the cloud r=benesch a=petermattis

For example, `[AWS]` or `[GCE]`.

Release note: None

Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Co-authored-by: Peter Mattis <petermattis@gmail.com>
Loading status checks…
3cefe76
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build succeeded

craig bot commented Oct 15, 2018

Build succeeded

@craig craig bot merged commit b08d662 into cockroachdb:master Oct 15, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@petermattis petermattis deleted the petermattis:pmattis/roachtest-slack branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment