Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprelease-2.1: storage: Avoid using different qps measurements in StoreRebalancer #31379
Conversation
a-robinson
requested a review
from
tschottdorf
Oct 15, 2018
a-robinson
requested a review
from cockroachdb/core-prs
as a
code owner
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This change is |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
tschottdorf
Oct 15, 2018
Member
LGTM
On Mon, Oct 15, 2018 at 7:39 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/31379>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#31379 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135Gloh2yjS2jSF-aEy9_QOt8PFjuzks5ulMhPgaJpZM4Xcz7->
.
--
…-- Tobias
|
LGTM
On Mon, Oct 15, 2018 at 7:39 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/31379>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#31379 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135Gloh2yjS2jSF-aEy9_QOt8PFjuzks5ulMhPgaJpZM4Xcz7->
.
--
…-- Tobias
|
a-robinson
merged commit ddbc2b8
into
cockroachdb:release-2.1
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
a-robinson commentedOct 15, 2018
Backport 1/1 commits from #31324.
/cc @cockroachdb/release
It's better to use the same measurement for everything, especially
because it's the one that was used to compute the store's total QPS.
Fixes #31303
Release note: None