Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprelease-2.1: storage: Jitter the StoreRebalancer loop's timing #31381
Conversation
a-robinson
requested review from
bdarnell and
tschottdorf
Oct 15, 2018
a-robinson
requested a review
from cockroachdb/core-prs
as a
code owner
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This change is |
a-robinson
merged commit c0bc4e0
into
cockroachdb:release-2.1
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
a-robinson commentedOct 15, 2018
Backport 1/1 commits from #31227.
/cc @cockroachdb/release
Release note: None
Just as a best practice. It may make failures like #31006 even less likely, although it's hard to say for sure.
Opening the PR just to get a final yes/no on this. The code has been tested more thoroughly without this change, so I'm fine to skip it, but there's also a benefit to all future master/2.2 testing being applicable to what's running in 2.1, rather than having 2.1 running code that is effectively only being tested in prod.