/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: more tests #31392

Merged
merged 3 commits into from Oct 15, 2018

Conversation

Reviewers

@mrtracy mrtracy

@cockroachdb/sql-ccl-prs sql-ccl-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@danhhz @cockroach-teamcity @mrtracy
@danhhz
Contributor

danhhz commented Oct 15, 2018

See commits for details.

danhhz added some commits Oct 10, 2018

@danhhz
changefeedccl: add a test for many changefeeds watching the same table 
Closes #31197

Release note: None
bb189dd
@danhhz
changefeedccl: test changefeed with unspecified primary key 
If the user doesn't specify a primary key when making the table, we add
one (a hidden `unique_rowid` column). This tests the behavior of a
changefeed over one of these tables.

Closes #31202

Release note: None
a403729
@danhhz
changefeedccl: test cursor= edge cases 
Closes #29661

Release note: None
Loading status checks…
ea0c5c8

@danhhz danhhz requested a review from mrtracy Oct 15, 2018

@danhhz danhhz requested a review from cockroachdb/sql-ccl-prs as a code owner Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable
@mrtracy

mrtracy approved these changes Oct 15, 2018
View changes

LGTM

@danhhz

This comment has been minimized.

Show comment
Hide comment
@danhhz

danhhz Oct 15, 2018

Contributor

TFTR!

bors r=mrtracy
Contributor

danhhz commented Oct 15, 2018

TFTR!

bors r=mrtracy

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @danhhz
Merge #31392 
31392: changefeedccl: more tests r=mrtracy a=danhhz

See commits for details.

Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Loading status checks…
6ce6187

@danhhz danhhz referenced this pull request Oct 15, 2018

Merged

release-2.1: changefeedccl: more tests #31397

@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build failed

craig bot commented Oct 15, 2018

Build failed
@danhhz

This comment has been minimized.

Show comment
Hide comment
@danhhz

danhhz Oct 15, 2018

Contributor

Flake looks like the same as #30491

bors r=mrtracy
Contributor

danhhz commented Oct 15, 2018

Flake looks like the same as #30491

bors r=mrtracy

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @danhhz
Merge #31392 
31392: changefeedccl: more tests r=mrtracy a=danhhz

See commits for details.

Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Loading status checks…
55cdc51
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build succeeded

craig bot commented Oct 15, 2018

Build succeeded

@craig craig bot merged commit ea0c5c8 into cockroachdb:master Oct 15, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@danhhz danhhz deleted the danhhz:cdc_tests branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment