/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: changefeedccl: more tests #31397

Merged
merged 3 commits into from Oct 16, 2018

Conversation

Reviewers

@mrtracy mrtracy

@cockroachdb/sql-ccl-prs sql-ccl-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@danhhz @cockroach-teamcity @mrtracy
@danhhz
Contributor

danhhz commented Oct 15, 2018

Backport 3/3 commits from #31392.

/cc @cockroachdb/release

See commits for details.

danhhz added some commits Oct 10, 2018

@danhhz
changefeedccl: add a test for many changefeeds watching the same table 
Closes #31197

Release note: None
a6bc879
@danhhz
changefeedccl: test changefeed with unspecified primary key 
If the user doesn't specify a primary key when making the table, we add
one (a hidden `unique_rowid` column). This tests the behavior of a
changefeed over one of these tables.

Closes #31202

Release note: None
ffe308f
@danhhz
changefeedccl: test cursor= edge cases 
Closes #29661

Release note: None
Loading status checks…
d62c1de

@danhhz danhhz requested a review from mrtracy Oct 15, 2018

@danhhz danhhz requested a review from cockroachdb/sql-ccl-prs as a code owner Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable
@mrtracy

mrtracy reviewed Oct 15, 2018
View changes

LGTM

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@mrtracy

mrtracy approved these changes Oct 16, 2018
View changes

:lgtm:

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@danhhz

This comment has been minimized.

Show comment
Hide comment
@danhhz

danhhz Oct 16, 2018

Contributor

TFTR!
Contributor

danhhz commented Oct 16, 2018

TFTR!

@danhhz danhhz merged commit 464baec into cockroachdb:release-2.1 Oct 16, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@danhhz danhhz deleted the danhhz:backport2.1-31392 branch Oct 16, 2018

This was referenced Oct 17, 2018

Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment