/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: minor verification fix #31399

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Reviewers

@benesch benesch

Assignees

@petermattis petermattis

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@andreimatei @cockroach-teamcity @benesch @petermattis
@andreimatei
Member

andreimatei commented Oct 15, 2018

The "cluster id" had been dropped in previous shuffles, probably because
I didn't truly understand what this function was doing.

Release note: None
@andreimatei
roachtest: minor verification fix 
The "cluster id" had been dropped in previous shuffles, probably because
I didn't truly understand what this function was doing.

Release note: None
Loading status checks…
73e1c58

@andreimatei andreimatei assigned petermattis Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable
@andreimatei

andreimatei reviewed Oct 15, 2018
View changes

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @andreimatei
Merge #31399 
31399: roachtest: minor verification fix r=andreimatei a=andreimatei

The "cluster id" had been dropped in previous shuffles, probably because
I didn't truly understand what this function was doing.

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Loading status checks…
35e8ee7
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build failed

craig bot commented Oct 15, 2018

Build failed
@andreimatei

This comment has been minimized.

Show comment
Hide comment
@andreimatei

andreimatei Oct 15, 2018

Member
Member

andreimatei commented Oct 15, 2018

craig bot pushed a commit that referenced this pull request Oct 15, 2018

craig[bot] @andreimatei
Merge #31399 
31399: roachtest: minor verification fix r=andreimatei a=andreimatei

The "cluster id" had been dropped in previous shuffles, probably because
I didn't truly understand what this function was doing.

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Loading status checks…
c9497fd
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 15, 2018

Build succeeded

craig bot commented Oct 15, 2018

Build succeeded

@craig craig bot merged commit 73e1c58 into cockroachdb:master Oct 15, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@andreimatei andreimatei deleted the andreimatei:roachtest-verify-name branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment