/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: deprecate TableDescriptor.UpVersion #31400

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Reviewers

@dt dt

@cockroachdb/core-prs core-prs

@cockroachdb/sql-wiring-prs sql-wiring-prs

@cockroachdb/sql-rest-prs sql-rest-prs

@cockroachdb/sql-execution-prs sql-execution-prs

@cockroachdb/sql-planning-prs sql-planning-prs

@cockroachdb/sql-async-prs sql-async-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vivekmenezes @cockroach-teamcity @dt
@vivekmenezes
Contributor

vivekmenezes commented Oct 15, 2018

The bit was already deprecated in 2.1. This removes all the
lingering code for the 2.2 release.

Release note: None

@vivekmenezes vivekmenezes requested a review from dt Oct 15, 2018

@vivekmenezes vivekmenezes requested review from cockroachdb/core-prs as code owners Oct 15, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 15, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 15, 2018

This change is Reviewable
@dt

dt approved these changes Oct 15, 2018
View changes

@vivekmenezes vivekmenezes requested a review from cockroachdb/sql-rest-prs as a code owner Oct 16, 2018

@vivekmenezes

This comment has been minimized.

Show comment
Hide comment
@vivekmenezes

vivekmenezes Oct 16, 2018

Contributor

bors r+
Contributor

vivekmenezes commented Oct 16, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 16, 2018

craig[bot] @vivekmenezes
Merge #31400 
31400: sql: deprecate TableDescriptor.UpVersion r=vivekmenezes a=vivekmenezes

The bit was already deprecated in 2.1. This removes all the
lingering code for the 2.2 release.

Release note: None

Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Loading status checks…
7e30565
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 16, 2018

Build failed

craig bot commented Oct 16, 2018

Build failed
@vivekmenezes
sql: deprecate TableDescriptor.UpVersion 
The bit was already deprecated in 2.1. This removes all the
lingering code for the 2.2 release.

Release note: None
Loading status checks…
3a5c7fe
@vivekmenezes

This comment has been minimized.

Show comment
Hide comment
@vivekmenezes

vivekmenezes Oct 16, 2018

Contributor

bors r+
Contributor

vivekmenezes commented Oct 16, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 16, 2018

craig[bot] @vivekmenezes
Merge #31400 
31400: sql: deprecate TableDescriptor.UpVersion r=vivekmenezes a=vivekmenezes

The bit was already deprecated in 2.1. This removes all the
lingering code for the 2.2 release.

Release note: None

Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Loading status checks…
a1c2f7d
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 16, 2018

Build succeeded

craig bot commented Oct 16, 2018

Build succeeded

@craig craig bot merged commit 3a5c7fe into cockroachdb:master Oct 16, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment