Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uproachtest: fix roachtest --cluster #31401
Conversation
andreimatei
assigned
benesch
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This change is |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
not ready yet, sorry |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
BramGruneir
Oct 15, 2018
Member
Perhaps we should revert the change that broke it and then you can take your time fixing this.
|
Perhaps we should revert the change that broke it and then you can take your time fixing this. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
ready for review now |
BramGruneir
approved these changes
Oct 15, 2018
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/cmd/roachtest/cluster.go, line 747 at r1 (raw file):
if !opt.skipStop { c.status("stopping cluster") c.All()
Why do you need to call all() here?
benesch
approved these changes
Oct 15, 2018
Reviewable status:
pkg/cmd/roachtest/cluster.go, line 747 at r1 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
Why do you need to call all() here?
Yeah, this looks spurious.
andreimatei
reviewed
Oct 15, 2018
TFTRs
bors r+
Reviewable status:
pkg/cmd/roachtest/cluster.go, line 747 at r1 (raw file):
Previously, benesch (Nikhil Benesch) wrote…
Yeah, this looks spurious.
debug leftover, sorry
bot
pushed a commit
that referenced
this pull request
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
craig
bot
commented
Oct 15, 2018
Build failed |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
bors r+ |
bot
pushed a commit
that referenced
this pull request
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
craig
bot
commented
Oct 15, 2018
Build failed |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
flake pinged to Nikhil. One more spin: |
bot
pushed a commit
that referenced
this pull request
Oct 15, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
craig
bot
commented
Oct 15, 2018
Build succeeded |
andreimatei commentedOct 15, 2018
•
edited
A recent commit delayed the setting of c.t, but some functions used by
attachToExistingCluster() were not prepated to work without c.t set.
This test introduces c.StartE/WipeE flavors that can be run on a cluster
that hasn't a test set yet.
Release note: None