/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: server(ccl)/ui: identify zone configs by zone name, not ID #31417

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Reviewers

@benesch benesch

@cockroachdb/core-prs core-prs

@cockroachdb/sql-ccl-prs sql-ccl-prs

@cockroachdb/admin-ui-prs admin-ui-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vilterp @cockroach-teamcity @benesch
@vilterp
Contributor

vilterp commented Oct 16, 2018

Backport 1/1 commits from #31407.

Not sure if this meets the bar — not a major bug, but would still be nice to have it fixed.

/cc @cockroachdb/release

Previously, the DataDistribution endpoint was returning a map of zone configs by zone config ID. However, zone config ID is not a unique identier within crdb_internal.zones, since subzones attached to partitions share the same ID (that of the top-level zone config), so map entries were being overwritten and the endpoint was returning an incomplete list.

Zone names should be unique; this change uses those instead and updates the UI accordingly.

This change also introduces a serverccl package for the unit test to live in, since testing this code path requires creating partitions, a CCL feature.

Fixes #27718

Release note: None
@vilterp
server(ccl)/ui: identify zone configs by zone name, not ID 
Previously, the DataDistribution endpoint was returning a map of zone
configs by zone config ID. However, zone config ID is not a unique
identier within `crdb_internal.zones`, since subzones attached to
partitions share the same ID (that of the top-level zone config).

Zone names should be unique; this change uses those instead and updates
the UI accordingly.

This change also introduces a `serverccl` package for the unit test to
live in, since testing this code path requires creating partitions, a
CCL feature.

Release note: None
Loading status checks…
d7254ab

@vilterp vilterp requested a review from benesch Oct 16, 2018

@vilterp vilterp requested review from cockroachdb/admin-ui-prs as code owners Oct 16, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 16, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 16, 2018

This change is Reviewable

@vilterp vilterp merged commit 4810e59 into cockroachdb:release-2.1 Oct 16, 2018
2 checks passed

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@vilterp vilterp deleted the vilterp:backport2.1-31407 branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment