/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Avoid using txn timestamp in gc test #31420

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Reviewers

@tschottdorf tschottdorf

@cockroachdb/core-prs core-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mvijaykarthik @cockroach-teamcity @tschottdorf
@mvijaykarthik
Contributor

mvijaykarthik commented Oct 16, 2018

Using transaction timstamp can lead to flaky tests.
Use constant timestamps while inserting events in rangelog
gc test.

Fixes #31371.

Release note: None
@mvijaykarthik
server: Avoid using txn timestamp in gc test 
Using transaction timstamp can lead to flaky tests.
Use constant timestamps while inserting events in rangelog
gc test.

Fixes #31371.

Release note: None
Loading status checks…
e93d201

@mvijaykarthik mvijaykarthik requested a review from cockroachdb/core-prs as a code owner Oct 16, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 16, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 16, 2018

This change is Reviewable
@tschottdorf

tschottdorf approved these changes Oct 16, 2018
View changes

Thanks!

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@tschottdorf

This comment has been minimized.

Show comment
Hide comment
@tschottdorf

tschottdorf Oct 16, 2018

Member

bors r+
Member

tschottdorf commented Oct 16, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 16, 2018

craig[bot] @mvijaykarthik
Merge #31420 
31420: server: Avoid using txn timestamp in gc test r=tschottdorf a=mvijaykarthik

Using transaction timstamp can lead to flaky tests.
Use constant timestamps while inserting events in rangelog
gc test.

Fixes #31371.

Release note: None

Co-authored-by: Vijay Karthik <vijay.karthik@rubrik.com>
Loading status checks…
24d6171
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 16, 2018

Build succeeded

craig bot commented Oct 16, 2018

Build succeeded

@craig craig bot merged commit e93d201 into cockroachdb:master Oct 16, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment