Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uproachtest: add tpccbench configurations that have caused instability #31466
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This change is |
petermattis
reviewed
Oct 16, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/cmd/roachtest/tpcc.go, line 768 at r1 (raw file):
EstimatedMax: 12000, LoadConfig: singlePartitionedLoadgen, },
These additional configurations might cause us to run over quota. Not sure what to do about that. @andreimatei's work to add CPU-level quota scheduling would help.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tschottdorf
Oct 16, 2018
Member
Are these run during nightlies? I really just want them in there so that we can take a look at them. If they run during nightlies, do they have a realistic failure criterion? Would be surprising given the problems we've seen in these.
|
Are these run during nightlies? I really just want them in there so that we can take a look at them. If they run during nightlies, do they have a realistic failure criterion? Would be surprising given the problems we've seen in these. |
petermattis
approved these changes
Oct 16, 2018
Oh, good point. I don't think these are run during nightlies. Carry on.
Reviewable status:
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@tschottdorf Do you want to merge this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Yep. Fixed the lint error. bors r=petermattis,nvanbenschoten |
bot
pushed a commit
that referenced
this pull request
Oct 17, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
craig
bot
commented
Oct 17, 2018
Build succeeded |
tschottdorf commentedOct 16, 2018
See #31409.
Release note: None