/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make build and tracing able to build cgo-free #31467

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Reviewers

@lopezator lopezator

@benesch benesch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dt @cockroach-teamcity @benesch @lopezator
@dt
Member

dt commented Oct 16, 2018

Release note: none.
@dt
build: make build and tracing able to build cgo-free 
Release note: none.
Verified
This commit was signed with a verified signature.
@dt dt David Taylor
GPG key ID: 01D8438FDFAE4E9A Learn about signing commits
Loading status checks…
72175b9

@dt dt requested a review from benesch Oct 16, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 16, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 16, 2018

This change is Reviewable
@dt

This comment has been minimized.

Show comment
Hide comment
@dt

dt Oct 16, 2018

Member

cc @lopezator
Member

dt commented Oct 16, 2018

cc @lopezator
@lopezator

lopezator reviewed Oct 16, 2018
View changes

:lgtm_strong:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@dt

This comment has been minimized.

Show comment
Hide comment
@dt

dt Oct 16, 2018

Member

@lopezator I still hit an issue building CGO_ENABLED=0 due to the strptime SQL builtin -- I submitted knz/strtime#1 to get that one.
Member

dt commented Oct 16, 2018

@lopezator I still hit an issue building CGO_ENABLED=0 due to the strptime SQL builtin -- I submitted knz/strtime#1 to get that one.
@dt

This comment has been minimized.

Show comment
Hide comment
@dt

dt Oct 16, 2018

Member

bors r+
Member

dt commented Oct 16, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 16, 2018

craig[bot] @dt
Merge #31467 
31467: build: make build and tracing able to build cgo-free r=dt a=dt

Release note: none.

Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Loading status checks…
26173e5
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 16, 2018

Build succeeded

craig bot commented Oct 16, 2018

Build succeeded

@craig craig bot merged commit 72175b9 into cockroachdb:master Oct 16, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@dt dt deleted the dt:nocgo branch Oct 16, 2018

@dt dt referenced this pull request Oct 16, 2018

Merged

sql: assert no dependencies on storage or CGo #31325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment