New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: add a retry loop around network activity #31508

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@BramGruneir
Member

BramGruneir commented Oct 16, 2018

This is a first attempt to try to address #31127 and #31298 by putting a retry
loop around anything that does any downloading. We've seen a number of flakes
because of iffy networking and this should hopefully solve the problem.

If this doesn't fix the issues, the next step it to add some alternative
sources to sources.list.d.

Release note: None

@BramGruneir BramGruneir requested a review from tschottdorf Oct 16, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 16, 2018

Member

This change is Reviewable

Member

cockroach-teamcity commented Oct 16, 2018

This change is Reviewable

@petermattis

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained


pkg/cmd/roachtest/hibernate.go, line 108 at r1 (raw file):

			// Build hibernate, this step involves some downloading, so it gets added
			// to the retry loop.

Starting the retry loop from scratch at this point seems unfortunate. The earlier parts seem reasonable to keep in the same loop, but I'm thinking this should be pulled out to a separate loop.

roachtest: add a retry loop around network activity
This is a first attempt to try to address #31127 and #31298 by putting a retry
loop around anything that does any downloading. We've seen a number of flakes
because of iffy networking and this should hopefully solve the problem.

If this doesn't fix the issues, the next step it to add some alternative
sources to sources.list.d.

Release note: None
@BramGruneir

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained


pkg/cmd/roachtest/hibernate.go, line 108 at r1 (raw file):

Previously, petermattis (Peter Mattis) wrote…

Starting the retry loop from scratch at this point seems unfortunate. The earlier parts seem reasonable to keep in the same loop, but I'm thinking this should be pulled out to a separate loop.

Done.

@petermattis

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained


pkg/cmd/roachtest/hibernate.go, line 111 at r2 (raw file):

		t.Status("building hibernate (without tests)")
		attempt = 0
		for r := retry.StartWithCtx(ctx, opts); r.Next(); {

I believe this can be for attempt, r := 0, retry.StartWithCtx(...); r.Next(); { ... }. Ditto for the loop above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment