/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix the color of the logout link #31513

Merged
merged 1 commit into from Oct 17, 2018
+7 −8

Conversation

Reviewers

@vilterp vilterp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@couchand @cockroach-teamcity @vilterp
@couchand
Member

couchand commented Oct 16, 2018

Release note: None

Before:
screen shot 2018-10-16 at 3 02 06 pm

After:
screen shot 2018-10-16 at 3 00 42 pm
@couchand
ui: fix the color of the logout link 
Release note: None
Loading status checks…
7b2dbb2

@couchand couchand requested a review from cockroachdb/admin-ui-prs as a code owner Oct 16, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 16, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 16, 2018

This change is Reviewable
@vilterp

vilterp approved these changes Oct 17, 2018
View changes

Good catch.

pkg/ui/styl/layout/navigation-bar.styl
@@ -97,6 +97,7 @@ $subnav-underline-height = 3px
display inline
padding 0
text-decoration none
color inherit

This comment has been minimized.

Show comment
Hide comment
@vilterp

vilterp Oct 17, 2018

Contributor

Hm, I thought it would inherit or "cascade" by default…
Copy link
@vilterp

vilterp Oct 17, 2018

Contributor

Hm, I thought it would inherit or "cascade" by default…

This comment has been minimized.

Show comment
Hide comment
@couchand

couchand Oct 17, 2018

Member

css 🤦‍♂️
Copy link
@couchand

couchand Oct 17, 2018

Member

css 🤦‍♂️
@couchand

This comment has been minimized.

Show comment
Hide comment
@couchand

couchand Oct 17, 2018

Member

bors r+
Member

couchand commented Oct 17, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 17, 2018

craig[bot] @couchand
Merge #31513 
31513: ui: fix the color of the logout link r=couchand a=couchand

Release note: None

---

Before:
<img width="89" alt="screen shot 2018-10-16 at 3 02 06 pm" src="https://user-images.githubusercontent.com/793969/47040553-7b3f3c80-d154-11e8-8f8b-f7469cbc6e8c.png">

After:
<img width="158" alt="screen shot 2018-10-16 at 3 00 42 pm" src="https://user-images.githubusercontent.com/793969/47040563-809c8700-d154-11e8-8c98-b98066ad7582.png">


Co-authored-by: Andrew Couch <andrew@cockroachlabs.com>
Loading status checks…
30be90f
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 17, 2018

Build succeeded

craig bot commented Oct 17, 2018

Build succeeded

@craig craig bot merged commit 7b2dbb2 into cockroachdb:master Oct 17, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment