sql: deflake TestSchemaChangeReverseMutations

[eriktrinh]

Fixes #31462.

Release note: None

[cockroach-teamcity]

This change is 

[cockroach-teamcity]

This change is 

[vivekmenezes]

Reviewable status: complete! 0 of 0 LGTMs obtained

---

pkg/sql/schema_changer_test.go, line 1779 at r1 (raw file):

	if _, err := addDefaultZoneConfig(sqlDB, tableDesc.ID); err != nil {
		t.Fatal(err)
	}

Any particular reason to need to reset it?

[eriktrinh]

Reviewable status: complete! 0 of 0 LGTMs obtained

---

pkg/sql/schema_changer_test.go, line 1779 at r1 (raw file):

Previously, vivekmenezes wrote…

Any particular reason to need to reset it?

The error is the same as #31177 and probably happens because the GC TTL is set to 0 so there is a race between the gc running and when the subsequent reads of this test occur. Resetting the GC TTL should prevent that.

[eriktrinh]

Reviewable status: complete! 0 of 0 LGTMs obtained

---

pkg/sql/schema_changer_test.go, line 1779 at r1 (raw file):

Previously, eriktrinh (Erik Trinh) wrote…

The error is the same as #31177 and probably happens because the GC TTL is set to 0 so there is a race between the gc running and when the subsequent reads of this test occur. Resetting the GC TTL should prevent that.

Restructured as discussed.

[vivekmenezes]

Reviewable status: complete! 0 of 0 LGTMs obtained

---

pkg/sql/schema_changer_test.go, line 1771 at r2 (raw file):

	// Wait until all the mutations have been processed.
	var rows *gosql.Rows

Do we need this to be defined?

[eriktrinh]

Reviewable status: complete! 0 of 0 LGTMs obtained

---

pkg/sql/schema_changer_test.go, line 1771 at r2 (raw file):

Previously, vivekmenezes wrote…

Do we need this to be defined?

Done.

[eriktrinh]

bors r+

[eriktrinh]

bors r+

[craig]

Build succeeded

• GitHub CI (Cockroach)

[craig]

Build succeeded

• GitHub CI (Cockroach)