Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upsql: use schema change lease only for long running schema changes #31530
Conversation
vivekmenezes
requested a review
from
dt
Oct 17, 2018
vivekmenezes
requested a review
from cockroachdb/sql-async-prs
as a
code owner
Oct 17, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
vivekmenezes commentedOct 17, 2018
Schema changes like RENAME TABLE that only change the schema
and run no data backfills need not need to hold the schema change
lease. The schema change post processing normally happens on
the gateway node. If the gateway fails, the post processing will
be picked up by another node. If more than one node picks it up,
they can all execute the post processing because it is idempotent.
fixes #18983
Release note: None