Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upissues: suggest stressrace, not stress #31548
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This change is |
tschottdorf
requested a review
from
petermattis
Oct 17, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
@petermattis (or anyone else): feel free to merge this. |
petermattis
approved these changes
Oct 17, 2018
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/cmd/internal/issues/issues.go, line 271 at r1 (raw file):
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh cd ~/go/src/github.com/cockroachdb/cockroach && \ make stressrace TESTS=%[5]s PKG=%[4]s TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log
I think we see if this is a race build from p.parameters(). In case you want to go the extra mile here.
benesch
approved these changes
Oct 18, 2018
LGTM, but we should probably just derive which to use based on whether the build specified GOFLAGS=-race.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tschottdorf commentedOct 17, 2018
Anecdotally, stressrace reproduces a larger percentage of failures.
Inspired by
#31000 (comment).
Release note: None