/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix artifacts publishing on TeamCity #31552

Merged
merged 1 commit into from Oct 17, 2018
+1 −1

Conversation

Reviewers

@jordanlewis jordanlewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@andreimatei @cockroach-teamcity @tschottdorf @jordanlewis
@andreimatei
Member

andreimatei commented Oct 17, 2018

Artifacts publishing broke recently when the way artifacts dirs started
being explicitly plumbed around. Before this patch, the wrong path was
being indicated to TC because test name was doubly-represented; it was
there both in the artifactsDir var and then we appended it again.

Release note: None
@andreimatei
roachtest: fix artifacts publishing on TeamCity 
Artifacts publishing broke recently when the way artifacts dirs started
being explicitly plumbed around. Before this patch, the wrong path was
being indicated to TC because test name was doubly-represented; it was
there both in the artifactsDir var and then we appended it again.

Release note: None
Loading status checks…
a754ab9

@andreimatei andreimatei requested a review from jordanlewis Oct 17, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 17, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 17, 2018

This change is Reviewable
@andreimatei

This comment has been minimized.

Show comment
Hide comment
@andreimatei

andreimatei Oct 17, 2018

Member

bors r+
Member

andreimatei commented Oct 17, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 17, 2018

craig[bot] @andreimatei
Merge #31552 
31552: roachtest: fix artifacts publishing on TeamCity r=andreimatei a=andreimatei

Artifacts publishing broke recently when the way artifacts dirs started
being explicitly plumbed around. Before this patch, the wrong path was
being indicated to TC because test name was doubly-represented; it was
there both in the artifactsDir var and then we appended it again.

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Loading status checks…
b821684
@tschottdorf

This comment has been minimized.

Show comment
Hide comment
@tschottdorf

tschottdorf Oct 17, 2018

Member

Thanks @andreimatei!
Member

tschottdorf commented Oct 17, 2018

Thanks @andreimatei!
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 17, 2018

Build failed

craig bot commented Oct 17, 2018

Build failed
@andreimatei

This comment has been minimized.

Show comment
Hide comment
@andreimatei

andreimatei Oct 17, 2018

Member
Member

andreimatei commented Oct 17, 2018

craig bot pushed a commit that referenced this pull request Oct 17, 2018

craig[bot] @andreimatei @mjibson
Merge #31552 #31553 
31552: roachtest: fix artifacts publishing on TeamCity r=andreimatei a=andreimatei

Artifacts publishing broke recently when the way artifacts dirs started
being explicitly plumbed around. Before this patch, the wrong path was
being indicated to TC because test name was doubly-represented; it was
there both in the artifactsDir var and then we appended it again.

Release note: None

31553: *: update to apd v2.0.0 r=mjibson a=mjibson

There was a breaking API change but it's now much safer to use.

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Loading status checks…
5b94de4
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 17, 2018

Build succeeded

craig bot commented Oct 17, 2018

Build succeeded

@craig craig bot merged commit a754ab9 into cockroachdb:master Oct 17, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment