/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update to apd v2.0.0 #31553

Merged
merged 1 commit into from Oct 17, 2018
+37 −42

Conversation

Reviewers

@danhhz danhhz

@cockroachdb/sql-wiring-prs sql-wiring-prs

@cockroachdb/sql-rest-prs sql-rest-prs

@cockroachdb/sql-execution-prs sql-execution-prs

@cockroachdb/sql-planning-prs sql-planning-prs

@cockroachdb/sql-async-prs sql-async-prs

@cockroachdb/build-prs build-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mjibson @cockroach-teamcity @danhhz
@mjibson
Member

mjibson commented Oct 17, 2018

There was a breaking API change but it's now much safer to use.

Release note: None
@mjibson
*: update to apd v2.0.0 
There was a breaking API change but it's now much safer to use.

Release note: None
Loading status checks…
b25f50c

@mjibson mjibson requested a review from danhhz Oct 17, 2018

@mjibson mjibson requested review from cockroachdb/build-prs as code owners Oct 17, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 17, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 17, 2018

This change is Reviewable
@danhhz

danhhz approved these changes Oct 17, 2018
View changes

@mjibson

This comment has been minimized.

Show comment
Hide comment
@mjibson

mjibson Oct 17, 2018

Member

bors r+
Member

mjibson commented Oct 17, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 17, 2018

craig[bot] @andreimatei @mjibson
Merge #31552 #31553 
31552: roachtest: fix artifacts publishing on TeamCity r=andreimatei a=andreimatei

Artifacts publishing broke recently when the way artifacts dirs started
being explicitly plumbed around. Before this patch, the wrong path was
being indicated to TC because test name was doubly-represented; it was
there both in the artifactsDir var and then we appended it again.

Release note: None

31553: *: update to apd v2.0.0 r=mjibson a=mjibson

There was a breaking API change but it's now much safer to use.

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Loading status checks…
5b94de4
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 17, 2018

Build succeeded

craig bot commented Oct 17, 2018

Build succeeded

@craig craig bot merged commit b25f50c into cockroachdb:master Oct 17, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@mjibson mjibson deleted the mjibson:apd-2 branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment