/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workloadccl: de-rot and unskip TestSetup #31555

Open
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@mrtracy mrtracy

@cockroachdb/sql-ccl-prs sql-ccl-prs

@benesch benesch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@danhhz @cockroach-teamcity @mrtracy
@danhhz
Contributor

danhhz commented Oct 17, 2018

I'm not 100% sure about this, but I think when 1bb7fa0 added the
--partition flag, the zone configs were silently dropped in this test.
7496288 would have caught it, but the test had already been skipped
by then.

Didn't see this flake repro with roachprodstress

60275 runs completed, 0 failures, over 1h24m26s

Closes #24655

Release note: None
@danhhz
workloadccl: de-rot and unskip TestSetup 
I'm not 100% sure about this, but I think when 1bb7fa0 added the
`--partition` flag, the zone configs were silently dropped in this test.
7496288 would have caught it, but the test had already been skipped
by then.

Didn't see this flake repro with roachprodstress

    60275 runs completed, 0 failures, over 1h24m26s

Closes #24655

Release note: None
Loading status checks…
04ae8c6

@danhhz danhhz requested a review from benesch Oct 17, 2018

@danhhz danhhz requested a review from cockroachdb/sql-ccl-prs as a code owner Oct 17, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 17, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 17, 2018

This change is Reviewable
@mrtracy

mrtracy approved these changes Oct 17, 2018
View changes

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment