/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: change schema change test timeout to 4 hrs #31560

Open
wants to merge 2 commits into
base: master
from

Conversation

Reviewers

@petermattis petermattis

@dt dt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vivekmenezes @cockroach-teamcity @petermattis
@vivekmenezes
Contributor

vivekmenezes commented Oct 17, 2018

Also rename schema change tests to always have a schemachange
prefix.

We ought to also rename the test files (for later)

related to #31526

Release note: None

@vivekmenezes vivekmenezes requested a review from dt Oct 17, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 17, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 17, 2018

This change is Reviewable
Show outdated Hide outdated pkg/cmd/roachtest/create_index.go Outdated
@vivekmenezes
roachtest: change schema change test timeout to 4 hrs 
Also rename schema change tests to always have a schemachange
prefix.

We ought to also rename the test files (for later)

related to #31526

Release note: None
7f82a54
@vivekmenezes

This comment has been minimized.

Show comment
Hide comment
@vivekmenezes

vivekmenezes Oct 18, 2018

Contributor

bors r+
Contributor

vivekmenezes commented Oct 18, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 18, 2018

craig[bot] @vivekmenezes
Merge #31560 
31560: roachtest: change schema change test timeout to 4 hrs r=vivekmenezes a=vivekmenezes

Also rename schema change tests to always have a schemachange
prefix.

We ought to also rename the test files (for later)

related to #31526

Release note: None

Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Loading status checks…
7291f5e
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 18, 2018

Build failed

craig bot commented Oct 18, 2018

Build failed
@vivekmenezes
roachtest: move schemachange/tpcc test to schemachange.go 
Release note: None
Loading status checks…
1eb1946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment