/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use the correct type annotation syntax in the typing RFC #31561

Merged
merged 1 commit into from Oct 18, 2018
+20 −20

Conversation

Reviewers

@nvanbenschoten nvanbenschoten

@knz knz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RaduBerinde @cockroach-teamcity @nvanbenschoten
@RaduBerinde
Member

RaduBerinde commented Oct 17, 2018

Release note: None
@RaduBerinde
docs: use the correct type annotation syntax in the typing RFC 
Release note: None
Loading status checks…
1d1bf97

@RaduBerinde RaduBerinde requested review from knz and nvanbenschoten Oct 17, 2018

@RaduBerinde RaduBerinde requested a review from cockroachdb/rfc-prs as a code owner Oct 17, 2018

@cockroach-teamcity

This comment has been minimized.

Show comment
Hide comment
@cockroach-teamcity

cockroach-teamcity Oct 17, 2018

Member

This change is Reviewable
Member

cockroach-teamcity commented Oct 17, 2018

This change is Reviewable
@nvanbenschoten

This comment has been minimized.

Show comment
Hide comment
@nvanbenschoten

nvanbenschoten Oct 17, 2018

Member

Thanks!
Member

nvanbenschoten commented Oct 17, 2018

Thanks!
@RaduBerinde

This comment has been minimized.

Show comment
Hide comment
@RaduBerinde

RaduBerinde Oct 18, 2018

Member

bors r+
Member

RaduBerinde commented Oct 18, 2018

bors r+

craig bot pushed a commit that referenced this pull request Oct 18, 2018

craig[bot] @RaduBerinde
Merge #31561 
31561: docs: use the correct type annotation syntax in the typing RFC r=RaduBerinde a=RaduBerinde

Release note: None

Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Loading status checks…
310a049
@craig

This comment has been minimized.

Show comment
Hide comment
@craig

craig bot Oct 18, 2018

Build succeeded

craig bot commented Oct 18, 2018

Build succeeded

@craig craig bot merged commit 1d1bf97 into cockroachdb:master Oct 18, 2018
3 checks passed

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@RaduBerinde RaduBerinde deleted the RaduBerinde:typing-rfc-colons branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment