Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upworkload/kv: add --secondary-index flag #31573
+11
−0
Conversation
nvanbenschoten
requested a review
from
a-robinson
Oct 18, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
This change is |
| @@ -121,6 +125,13 @@ func (w *kv) Hooks() workload.Hooks { | ||
| } | ||
| return nil | ||
| }, | ||
| PostLoad: func(sqlDB *gosql.DB) error { | ||
| if w.secondaryIndex { | ||
| _, err := sqlDB.Exec(`CREATE INDEX IF NOT EXISTS v_idx ON kv (v)`) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
tschottdorf
Oct 18, 2018
Member
Is this going to be backfilled in the background? If so, the impact of that will be pretty nondeterministic. Maybe that doesn't matter now, but perhaps call it out on the flag.
tschottdorf
Oct 18, 2018
Member
Is this going to be backfilled in the background? If so, the impact of that will be pretty nondeterministic. Maybe that doesn't matter now, but perhaps call it out on the flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nvanbenschoten commentedOct 18, 2018
The flag instructs schema initialization to add a secondary index
on the
vcolumn. This has been useful for experimenting with theperf impact of secondary indexes.
Release note: None