Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
hlc: remove locking in Physical(Now|Time), addresses 30520 #32225
left a comment
I don't think Github will pick this up. Try one of these: https://help.github.com/articles/closing-issues-using-keywords/.
@bdarnell, want to take a look?
Let's name these methods something even more clear. How about
pushed a commit
this pull request
Nov 12, 2018
We do see these two methods show up on large machines in CPU and mutex profiles. I've also seen them be the cause of goroutine preemption in execution traces. I'd spin up a single-node cluster with a 32-core machine and hit it with