New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes: Increase default disk size to 100 GiB #32428

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@a-robinson
Copy link
Collaborator

a-robinson commented Nov 16, 2018

Minikube used to have issues with large disks, but doesn't complain
about them anymore. I don't know when this changed, but now we can
increase the default disk size to make everyone happier.

Release note (general change): The default disk size on Kubernetes has
been changed from 1 GiB to 100 GiB.

@a-robinson a-robinson requested review from bobvawter and jseldess Nov 16, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Nov 16, 2018

This change is Reviewable

@jseldess
Copy link
Contributor

jseldess left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

kubernetes: Increase default disk size to 100 GiB
Minikube used to have issues with large disks, but doesn't complain
about them anymore. I don't know when this changed, but now we can
increase the default disk size to make everyone happier.

Release note (general change): The default disk size on Kubernetes has
been changed from 1 GiB to 100 GiB.

@a-robinson a-robinson force-pushed the a-robinson:disksize branch from 7d7444f to 152dc1d Nov 19, 2018

@a-robinson

This comment has been minimized.

Copy link
Collaborator

a-robinson commented Nov 19, 2018

bors r+

craig bot pushed a commit that referenced this pull request Nov 19, 2018

Merge #32428
32428: kubernetes: Increase default disk size to 100 GiB r=a-robinson a=a-robinson

Minikube used to have issues with large disks, but doesn't complain
about them anymore. I don't know when this changed, but now we can
increase the default disk size to make everyone happier.

Release note (general change): The default disk size on Kubernetes has
been changed from 1 GiB to 100 GiB.

Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Nov 19, 2018

Build succeeded

@craig craig bot merged commit 152dc1d into cockroachdb:master Nov 19, 2018

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment