New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulkio: add SESSION_TOKEN to S3 config. #32455

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
4 participants
@shakeelrao
Copy link
Contributor

shakeelrao commented Nov 18, 2018

Allows the client to pass a SESSION_TOKEN query parameter with an S3 URL.

Fixes #32276

@shakeelrao shakeelrao requested review from cockroachdb/core-prs as code owners Nov 18, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Nov 18, 2018

This change is Reviewable

@shakeelrao shakeelrao changed the title storageccl: add SESSION_TOKEN to S3 config. bulkio: add SESSION_TOKEN to S3 config. Nov 18, 2018

@shakeelrao

This comment has been minimized.

Copy link
Contributor

shakeelrao commented Nov 18, 2018

I wasn't entirely sure of the scope of this issue, but I would be more than happy refine my solution if needed.

@mjibson

This comment has been minimized.

Copy link
Member

mjibson commented Nov 19, 2018

Code LGTM

storageccl: add SESSION_TOKEN to S3 config.
Allows the client to pass a SESSION_TOKEN query parameter with an S3 URL.

Release note (enterprise change): It is now possible to use AWS S3
temporary credentials for BACKUP/RESTORE and IMPORT/EXPORT using the
AWS_SESSION_TOKEN parameter in the URL.

@knz knz force-pushed the shakeelrao:s3-session-token branch from fbcca62 to 7118c0a Dec 5, 2018

@knz

This comment has been minimized.

Copy link
Member

knz commented Dec 5, 2018

@shakeelrao thank you for your contribution! This is very good. I have amended the commit message to include a release note.

@mjibson are you ok to merge this? I don't know about tests, but I am not sure we can automate a test anyway.

@knz knz added this to Triage in Bulk IO via automation Dec 5, 2018

@mjibson

This comment has been minimized.

Copy link
Member

mjibson commented Dec 5, 2018

bors r+

craig bot pushed a commit that referenced this pull request Dec 5, 2018

Merge #32455
32455: bulkio: add SESSION_TOKEN to S3 config. r=mjibson a=shakeelrao

Allows the client to pass a SESSION_TOKEN query parameter with an S3 URL.

Fixes #32276

Co-authored-by: shakeelrao <shakeelrao79@gmail.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Dec 5, 2018

Build succeeded

@craig craig bot merged commit 7118c0a into cockroachdb:master Dec 5, 2018

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment