New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: fix avro buglet #32474

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@danhhz
Copy link
Contributor

danhhz commented Nov 19, 2018

Classic "taking the address of a for-loop local variable buglet". Was
breaking any columns with width or precision set.

Closes #32471

Release note (bug fix): experimental_avro CHANGEFEEDs now work with
column WIDTHs and PRECISIONs

@danhhz danhhz requested a review from mrtracy Nov 19, 2018

@danhhz danhhz requested a review from cockroachdb/sql-ccl-prs as a code owner Nov 19, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Nov 19, 2018

This change is Reviewable

@mrtracy
Copy link
Collaborator

mrtracy left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

changefeedccl: fix avro buglet
Classic "taking the address of a for-loop local variable buglet". Was
breaking any columns with width or precision set.

Closes #32471

Release note (bug fix): experimental_avro CHANGEFEEDs now work with
column WIDTHs and PRECISIONs

@danhhz danhhz force-pushed the danhhz:cdc_avro branch from 4460635 to 2efb998 Nov 19, 2018

@danhhz

This comment has been minimized.

Copy link
Contributor

danhhz commented Nov 19, 2018

TFTR!

bors r=mrtracy

craig bot pushed a commit that referenced this pull request Nov 19, 2018

Merge #32474
32474: changefeedccl: fix avro buglet r=mrtracy a=danhhz

Classic "taking the address of a for-loop local variable buglet". Was
breaking any columns with width or precision set.

Closes #32471

Release note (bug fix): experimental_avro CHANGEFEEDs now work with
column WIDTHs and PRECISIONs

Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Nov 19, 2018

Build succeeded

@craig craig bot merged commit 2efb998 into cockroachdb:master Nov 19, 2018

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@danhhz danhhz deleted the danhhz:cdc_avro branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment