New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix the pretty-printing for FK actions SET DEFAULT and SET NULL #32589

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@knz
Copy link
Member

knz commented Nov 26, 2018

Fixes #32529.

Release note (bug fix): CockroachDB now properly handles foreign key
cascading actions SET DEFAULT and SET NULL in SHOW CREATE and
cockroach dump.

sql: fix the pretty-printing for FK actions SET DEFAULT and SET NULL
Release note (bug fix): CockroachDB now properly handles foreign key
cascading actions `SET DEFAULT` and `SET NULL` in `SHOW CREATE` and
`cockroach dump`.

@knz knz requested a review from mjibson Nov 26, 2018

@knz knz added this to Triage in SQL Front-end, Lang & Semantics via automation Nov 26, 2018

@knz knz requested review from cockroachdb/sql-async-prs as code owners Nov 26, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Nov 26, 2018

This change is Reviewable

@knz knz moved this from Triage to Current milestone in SQL Front-end, Lang & Semantics Nov 26, 2018

@knz

This comment has been minimized.

Copy link
Member

knz commented Nov 27, 2018

bors r+

craig bot pushed a commit that referenced this pull request Nov 27, 2018

Merge #32589
32589: sql: fix the pretty-printing for FK actions SET DEFAULT and SET NULL r=knz a=knz

Fixes #32529.

Release note (bug fix): CockroachDB now properly handles foreign key
cascading actions `SET DEFAULT` and `SET NULL` in `SHOW CREATE` and
`cockroach dump`.

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Nov 27, 2018

Build succeeded

@craig craig bot merged commit e044cad into cockroachdb:master Nov 27, 2018

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@knz knz moved this from Current milestone to Finished (m2.2-2) in SQL Front-end, Lang & Semantics Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment