New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: return ErrNotExist from DeleteFile on Windows #32664

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@tbg
Copy link
Member

tbg commented Nov 28, 2018

Fixes #32593.

Release note (bug fix): Fixed a crash that could occur during or after a
data import on Windows.

engine: return ErrNotExist from DeleteFile on Windows
Fixes #32593.

Release note (bug fix): Fixed a crash that could occur during or after a
data import on Windows.

@tbg tbg requested a review from cockroachdb/core-prs as a code owner Nov 28, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Nov 28, 2018

This change is Reviewable

@tbg tbg requested a review from benesch Nov 28, 2018

@petermattis
Copy link
Contributor

petermattis left a comment

This is quite ugly.

@tbg

This comment has been minimized.

Copy link
Member

tbg commented Nov 28, 2018

Definitely. Let me know if you think we can do better. But ISTM that RocksDB doesn't even have any useful structure in their IOError:

https://github.com/cockroachdb/rocksdb/blob/0a3db28d98e5f057a732cf0f636d8470fc11ee71/include/rocksdb/status.h#L47-L77

@tbg

This comment has been minimized.

Copy link
Member

tbg commented Nov 28, 2018

bors r=petermattis

craig bot pushed a commit that referenced this pull request Nov 28, 2018

Merge #32664
32664: engine: return ErrNotExist from DeleteFile on Windows r=petermattis a=tbg

Fixes #32593.

Release note (bug fix): Fixed a crash that could occur during or after a
data import on Windows.

Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Nov 28, 2018

Build succeeded

@craig craig bot merged commit 822eee2 into cockroachdb:master Nov 28, 2018

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@tbg tbg deleted the tbg:fix/windows-not-found branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment