/cockroach

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move raft-related tests out of store_split_test.go. #327

Merged
merged 1 commit into from Feb 17, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bdarnell @BramGruneir @petermattis
@bdarnell
Member

bdarnell commented Feb 17, 2015

Rename all tests in package storage_test.go to client_*_test.go
to make the division clearer.

@spencerkimball @cockroachdb/developers
@BramGruneir

This comment has been minimized.

Show comment
Hide comment
@BramGruneir

BramGruneir Feb 17, 2015

Member

LGTM
Member

BramGruneir commented Feb 17, 2015

LGTM
Show outdated Hide outdated storage/client_raft_test.go Outdated
@petermattis

This comment has been minimized.

Show comment
Hide comment
@petermattis

petermattis Feb 17, 2015

Contributor

LGTM
Contributor

petermattis commented Feb 17, 2015

LGTM
@bdarnell
Move raft-related tests out of store_split_test.go. 
Rename all tests in package storage_test.go to client_*_test.go
to make the division clearer.
7fb9c0e

bdarnell added a commit that referenced this pull request Feb 17, 2015

@bdarnell
Merge pull request #327 from bdarnell/storage-client-tests 
Move raft-related tests out of store_split_test.go.
54df5e1

@bdarnell bdarnell merged commit 54df5e1 into cockroachdb:master Feb 17, 2015
1 check was pending

1 check was pending

ci/circleci CircleCI is running your tests
Details

@bdarnell bdarnell deleted the bdarnell:storage-client-tests branch Feb 17, 2015

andreimatei pushed a commit to andreimatei/cockroach that referenced this pull request Mar 21, 2017

@iamqizhao
Merge pull request cockroachdb#327 from iamqizhao/master 
tentatively disable content-type check
6b6127d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment