New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload/cli: stop including data-only generators in workload run #32720

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@danhhz
Copy link
Contributor

danhhz commented Nov 29, 2018

Release note(bug fix): cockroach workload run no longer includes
data-only generators

@danhhz danhhz requested a review from benesch Nov 29, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Nov 29, 2018

This change is Reviewable

workload/cli: stop including data-only generators in workload run
Release note(bug fix): `cockroach workload run` no longer includes
data-only generators

@danhhz danhhz force-pushed the danhhz:workload_run branch from a5fbb4a to 771a0fe Nov 30, 2018

@danhhz danhhz requested a review from cockroachdb/cli-prs as a code owner Nov 30, 2018

@danhhz

This comment has been minimized.

Copy link
Contributor

danhhz commented Dec 4, 2018

paging @benesch : - )

@benesch

benesch approved these changes Dec 4, 2018

Copy link
Collaborator

benesch left a comment

Gah, sorry!

@danhhz

This comment has been minimized.

Copy link
Contributor

danhhz commented Dec 4, 2018

No worries! Sorry you're stuck with doing these reviews. Doesn't seem worth getting someone else ramped up on so much workload stuff for such small PRs.

bors r=benesch

craig bot pushed a commit that referenced this pull request Dec 4, 2018

Merge #32720
32720: workload/cli: stop including data-only generators in workload run r=benesch a=danhhz

Release note(bug fix): `cockroach workload run` no longer includes
data-only generators

Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Dec 4, 2018

Build succeeded

@craig craig bot merged commit 771a0fe into cockroachdb:master Dec 4, 2018

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@danhhz danhhz deleted the danhhz:workload_run branch Dec 4, 2018

@jseldess

This comment has been minimized.

Copy link
Contributor

jseldess commented Dec 14, 2018

@danhhz, I still see startrek and intro listed as possible commands in the help text for cockroach workload run. Is that an oversight or am I misunderstanding?

~/go/src/github.com/cockroachdb/cockroach$ cockroach workload run --help
[experimental] run a workload's operations against a cluster

Usage:
  cockroach workload run [flags]
  cockroach workload run [command]

Available Commands:
  bank        [experimental] Bank models a set of accounts with currency balances
  intro       [experimental] Intro contains a single table with a hidden message
  startrek    [experimental] Star Trek models episodes and quotes from the tv show
  tpcc        [experimental] TPC-C simulates a transaction processing workload using a rich schema of multiple tables

Flags:
  -h, --help   help for run

Global Flags:
      --logtostderr Severity[=DEFAULT]   logs at or above this threshold go to stderr (default NONE)
      --no-color                         disable standard error log colorization
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging (significantly hurts performance)

Use "cockroach workload run [command] --help" for more information about a command.
~/go/src/github.com/cockroachdb/cockroach$ cockroach workload run startrek
Error: no operations defined for startrek
~/go/src/github.com/cockroachdb/cockroach$ cockroach workload run intro
Error: no operations defined for intro
@jseldess

This comment has been minimized.

Copy link
Contributor

jseldess commented Dec 14, 2018

Nevermind. I was using a 2.2 binary. 2.1 looks good.

@danhhz

This comment has been minimized.

Copy link
Contributor

danhhz commented Dec 14, 2018

Nevermind. I was using a 2.2 binary. 2.1 looks good.

@jseldess I just double-checked master and it works there too. Maybe we haven't released a 2.2 alpha since this went in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment