New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix the evaluation of CHECK after ON CONFLICT DO UPDATE SET #32779

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@knz
Copy link
Member

knz commented Dec 3, 2018

Fixes #32762.

Release note (bug fix): CockroachDB now properly evaluates CHECK
constraints after a row conflict in INSERT ON CONFLICT, when the CHECK
constraint depends on a column not assigned by DO UPDATE SET.

@knz knz requested review from bobvawter and BramGruneir Dec 3, 2018

@knz knz requested review from cockroachdb/sql-execution-prs as code owners Dec 3, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Dec 3, 2018

This change is Reviewable

@bobvawter
Copy link
Contributor

bobvawter left a comment

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

sql: fix the evaluation of CHECK after ON CONFLICT DO UPDATE SET
Release note (bug fix): CockroachDB now properly evaluates CHECK
constraints after a row conflict in INSERT ON CONFLICT, when the CHECK
constraint depends on a column not assigned by DO UPDATE SET.

@knz knz force-pushed the knz:20181203-upsert branch from 6a2fc04 to 1318a8d Dec 3, 2018

@knz

This comment has been minimized.

Copy link
Member

knz commented Dec 3, 2018

bors r+

craig bot pushed a commit that referenced this pull request Dec 3, 2018

Merge #32779
32779: sql: fix the evaluation of CHECK after ON CONFLICT DO UPDATE SET r=knz a=knz

Fixes  #32762.

Release note (bug fix): CockroachDB now properly evaluates CHECK
constraints after a row conflict in INSERT ON CONFLICT, when the CHECK
constraint depends on a column not assigned by DO UPDATE SET.

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Dec 3, 2018

Build succeeded

@craig craig bot merged commit 1318a8d into cockroachdb:master Dec 3, 2018

2 of 3 checks passed

GitHub CI (Cockroach) TeamCity build failed
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@knz knz deleted the knz:20181203-upsert branch Dec 3, 2018

@knz knz moved this from Triage to Current milestone in SQL Front-end, Lang & Semantics Dec 3, 2018

@knz knz moved this from Current milestone to Finished (m2.2-2) in SQL Front-end, Lang & Semantics Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment