release-2.1: changefeedccl: add logs for slow ExportRequests and frontier spans #32869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metrics added in cockroachdb#32241 are great for monitoring the health of a changefeed and roughly debugging performance issues. Many of the ones I've been seeing in testing have been one or many spans being behind, so add some debug logging with details on the keys and lag, which then allows for more targeted investigation. Release note: None
|
This change is |
mrtracy
approved these changes
Dec 5, 2018
complete! 0 of 0 LGTMs obtained
|
Closing this in favor of #32872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #32728.
/cc @cockroachdb/release
The metrics added in #32241 are great for monitoring the health of a
changefeed and roughly debugging performance issues. Many of the ones
I've been seeing in testing have been one or many spans being behind, so
add some debug logging with details on the keys and lag, which then
allows for more targeted investigation.
Release note: None