New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: changefeed performance debugging #32872

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@danhhz
Copy link
Contributor

danhhz commented Dec 5, 2018

Backport:

  • 1/1 commits from "changefeedccl: add metrics for performance debugging" (#32241)
  • 1/1 commits from "changefeedccl: add logs for slow ExportRequests and frontier spans" (#32728)

Please see individual PRs for details.

/cc @cockroachdb/release

danhhz added some commits Nov 13, 2018

changefeedccl: add metrics for performance debugging
I've been running a branch with a bunch of extra metrics while debugging
issue #32104. PR'ing the ones that have proven useful in case someone
has performance issues in the wild.

Release note (enterprise change): Added timeseries metrics for debugging
CHANGEFEED performance issues.
changefeedccl: add logs for slow ExportRequests and frontier spans
The metrics added in #32241 are great for monitoring the health of a
changefeed and roughly debugging performance issues. Many of the ones
I've been seeing in testing have been one or many spans being behind, so
add some debug logging with details on the keys and lag, which then
allows for more targeted investigation.

Release note: None

@danhhz danhhz requested a review from mrtracy Dec 5, 2018

@danhhz danhhz requested review from cockroachdb/core-prs as code owners Dec 5, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Dec 5, 2018

This change is Reviewable

@mrtracy

mrtracy approved these changes Dec 6, 2018

Copy link
Contributor

mrtracy left a comment

LGTM

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@danhhz danhhz merged commit 1d5c68b into cockroachdb:release-2.1 Dec 7, 2018

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@danhhz danhhz deleted the danhhz:backport2.1-32241-32728 branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment