New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: build: link libncurses statically #32960

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@knz
Copy link
Member

knz commented Dec 9, 2018

Backport 1/1 commits from #32959.

/cc @cockroachdb/release


Fixes #32281.

build: link libncurses statically
The Unix world is in the process of upgrading from libncurses ABI 5.0 to
libncurses ABI 6.0. The ABIs are incompatible in both directions, so we
can't support systems that ship libncurses 5.0 and systems that ship
libncurses 6.0 at the same time.

Link libncurses statically to sidestep the issue.

Note that we don't bother vendoring ncurses like we do for our other
C/C++ dependencies, because we don't particularly care about what
version of ncurses we link. Nearly all extant versions of ncurses
(5.0-6.1) are source compatible, and bug fixes in recent releases rarely
affect the low-level terminfo APIs that we depend upon.

Take the opportunity to upgrade to ncurses 6.1 as well. It doesn't fix
any bugs we know of, but it's good to stay up to date.

Fix #32281.

Release note (build change): ncurses is now linked statically so that
the cockroach binary no longer requires a particular version of the
ncurses shared library to be available on deployment machines.

@knz knz requested a review from benesch Dec 9, 2018

@knz knz requested a review from cockroachdb/build-prs as a code owner Dec 9, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Dec 9, 2018

This change is Reviewable

@knz

This comment has been minimized.

Copy link
Member

knz commented Dec 9, 2018

LGTM but @benesch please:

  1. feel free to chime in if you can think of any reason why we should not merge this

  2. you get the honor of pushing the green button

@knz

This comment has been minimized.

Copy link
Member

knz commented Dec 9, 2018

Note that I am finding myself shy of backporting this further to release-2.0 due to the numerous makefile/builder changes since April.

@benesch benesch merged commit 8c4cd6b into cockroachdb:release-2.1 Dec 10, 2018

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
@benesch

This comment has been minimized.

Copy link
Collaborator

benesch commented Dec 10, 2018

Thanks, @knz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment