New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport-2.1: storage: delay manual splits that would result in more snapshots #33015

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@tbg
Copy link
Member

tbg commented Dec 11, 2018

Backports #32594. This didn't apply cleanly, but only because I never
cherry-picked #32594 and #32594 refers a variable introduced within.

Fixes #32898.
Fixes #32900.
Fixes #32895.

/cc @cockroachdb/release

Release note (bug fix): resolve a cluster degradation scenario that
could occur during IMPORT/RESTORE operations, manifested through a
high number of pending Raft snapshots.

@tbg tbg requested a review from cockroachdb/core-prs as a code owner Dec 11, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Dec 11, 2018

This change is Reviewable

@tbg tbg force-pushed the tbg:backport2.1-32594 branch from 5438455 to 0d98476 Dec 11, 2018

@tbg tbg requested a review from petermattis Dec 11, 2018

backport-2.1: storage: delay manual splits that would result in more …
…snapshots

Backports #32594. This didn't apply cleanly, but only because I never
cherry-picked #32594 and #32594 refers a variable introduced within.

Fixes #32898.
Fixes #32900.
Fixes #32895.

/cc @cockroachdb/release

Release note (bug fix): resolve a cluster degradation scenario that
could occur during IMPORT/RESTORE operations, manifested through a
high number of pending Raft snapshots.

@tbg tbg force-pushed the tbg:backport2.1-32594 branch from 0d98476 to a830397 Dec 11, 2018

@petermattis
Copy link
Contributor

petermattis left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@tbg tbg merged commit 138369e into cockroachdb:release-2.1 Dec 11, 2018

2 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details

@tbg tbg deleted the tbg:backport2.1-32594 branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment