Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
release-2.1: storage: Fix GetNeededReplicas to count non-live, non-dead nodes #33047
For anyone else wondering, the bug looks "new" in the diff of #30559 but was actually already in the old code. The reason it doesn't show up in the diff is because it was changed; instead the new method
That method remains untouched by all of these fixes. I think this is OK because its callers want a certified live store to transfer ranges or leases to, so we don't actually want to return nodes that are non-live. Still, the method description doesn't properly explain the semantics.
Yes, that's correct. Most of the rebalancing code really does only want nodes that are currently live. It's a subtlety that we aren't handling very well, though, as we discussed last night.