Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: distsqlplan: fix error in union planning #34913

Merged
merged 1 commit into from Feb 14, 2019

Conversation

@jordanlewis
Copy link
Member

commented Feb 14, 2019

Backport 1/1 commits from #34762.

/cc @cockroachdb/release


Previously, if 2 inputs to a UNION ALL had identical post processing
except for renders, further post processing on top of that union all
could invalidate the plan and cause errors or crashes.

Fixes #34437.

Release note (bug fix): fix a planning crash during UNION ALL operations
that had projections, filters or renders directly on top of the UNION
ALL in some cases.

Previously, if 2 inputs to a UNION ALL had identical post processing
except for renders, further post processing on top of that union all
could invalidate the plan and cause errors or crashes.

Release note (bug fix): fix a planning crash during UNION ALL operations
that had projections, filters or renders directly on top of the UNION
ALL in some cases.
@jordanlewis jordanlewis requested a review from RaduBerinde Feb 14, 2019
@jordanlewis jordanlewis requested review from cockroachdb/distsql-prs as code owners Feb 14, 2019
@jordanlewis jordanlewis requested a review from Feb 14, 2019
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

This change is Reviewable

@jordanlewis jordanlewis merged commit 2793863 into cockroachdb:release-2.1 Feb 14, 2019
2 checks passed
2 checks passed
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
@jordanlewis jordanlewis deleted the jordanlewis:backport2.1-34762 branch Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.