Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: turn on zigzag joins by default #35911

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@justinj
Copy link
Member

commented Mar 18, 2019

Release note (sql change): Zigzag joins will now be planned by the
optimizer in certain cases. They were previously available via the
experimental_enable_zigzag_join session variable and can still be
disabled by setting that value to "false".

@justinj justinj requested review from rytaft and RaduBerinde Mar 18, 2019

@justinj justinj requested review from cockroachdb/sql-execution-prs as code owners Mar 18, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

This change is Reviewable

@RaduBerinde
Copy link
Member

left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @rytaft)

@andy-kimball

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

You wasted no time enabling this for 19.2! (I assume this is not getting backported, right?)

opt: turn on zigzag joins by default
Release note (sql change): Zigzag joins will now be planned by the
optimizer in certain cases. They were previously available via the
`experimental_enable_zigzag_join` session variable and can still be
disabled by setting that value to "false".

@justinj justinj force-pushed the justinj:enable-zigzag branch from 3d893e4 to 1969ec6 Mar 19, 2019

@justinj

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

No time like the present!

And certainly not :)

@rytaft

rytaft approved these changes Mar 19, 2019

Copy link
Contributor

left a comment

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale)

@justinj

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

bors r+

craig bot pushed a commit that referenced this pull request Mar 19, 2019

Merge #35911
35911: opt: turn on zigzag joins by default r=justinj a=justinj

Release note (sql change): Zigzag joins will now be planned by the
optimizer in certain cases. They were previously available via the
`experimental_enable_zigzag_join` session variable and can still be
disabled by setting that value to "false".

Co-authored-by: Justin Jaffray <justin@cockroachlabs.com>
@craig

This comment has been minimized.

Copy link

commented Mar 19, 2019

Build succeeded

@craig craig bot merged commit 1969ec6 into cockroachdb:master Mar 19, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.