Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: remove deprecated changefeed.min_high_water metric #36915

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
3 participants
@danhhz
Copy link
Contributor

commented Apr 17, 2019

It was replaced by max_behind_nanos in 19.1.

Release note (backwards-incompatible change): Removed the deprecated
changefeed.min_high_water metric; use changefeed.max_behind_nanos
instead.

changefeedccl: remove deprecated changefeed.min_high_water metric
It was replaced by max_behind_nanos in 19.1.

Release note (backwards-incompatible change): Removed the deprecated
`changefeed.min_high_water` metric; use `changefeed.max_behind_nanos`
instead.

@danhhz danhhz requested review from tbg and nvanbenschoten Apr 17, 2019

@danhhz danhhz requested a review from cockroachdb/sql-ccl-prs as a code owner Apr 17, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

This change is Reviewable

@danhhz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

TFTR!

bors r=nvanbenschoten

craig bot pushed a commit that referenced this pull request Apr 17, 2019

Merge #36867 #36915
36867: storage: take an engine checkpoint during failing consistency checks r=andreimatei a=tbg

This takes a checkpoint on the nodes with replicas of a failing range,
before the failure leads to nodes shutting down. The checkpoint will, for
the replicas of the affected range, be taken at the same Raft log position.

Release note: None

36915: changefeedccl: remove deprecated changefeed.min_high_water metric r=nvanbenschoten a=danhhz

It was replaced by max_behind_nanos in 19.1.

Release note (backwards-incompatible change): Removed the deprecated
`changefeed.min_high_water` metric; use `changefeed.max_behind_nanos`
instead.

Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
@craig

This comment has been minimized.

Copy link

commented Apr 17, 2019

Build succeeded

@craig craig bot merged commit 019641d into cockroachdb:master Apr 17, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@danhhz danhhz deleted the danhhz:cdc_metric branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.