Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlbase: fix array encoding for arrays of wrapped types #37170

Merged
merged 1 commit into from Apr 27, 2019

Conversation

Projects
None yet
3 participants
@jordanlewis
Copy link
Member

commented Apr 26, 2019

Previously, it was impossible to encode arrays with element types that
required oid wrapping (DName and DOid).

Fixes #36736.

Release note (bug fix): make it possible to write to columns of type
name[].

@jordanlewis jordanlewis requested a review from andy-kimball Apr 26, 2019

@jordanlewis jordanlewis requested review from cockroachdb/sql-async-prs as code owners Apr 26, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

This change is Reviewable

@andy-kimball
Copy link
Contributor

left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andy-kimball)

sqlbase: fix array encoding for arrays of wrapped types
Previously, it was impossible to encode arrays with element types that
required oid wrapping (DName and DOid).

Release note (bug fix): make it possible to write to columns of type
name[].

@jordanlewis jordanlewis force-pushed the jordanlewis:fix-doid-wrapped-array branch from 7aaaa49 to c593628 Apr 27, 2019

@jordanlewis

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Apr 27, 2019

Merge #37170
37170: sqlbase: fix array encoding for arrays of wrapped types r=jordanlewis a=jordanlewis

Previously, it was impossible to encode arrays with element types that
required oid wrapping (DName and DOid).

Fixes #36736.

Release note (bug fix): make it possible to write to columns of type
name[].

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig

This comment has been minimized.

Copy link

commented Apr 27, 2019

Build succeeded

@craig craig bot merged commit c593628 into cockroachdb:master Apr 27, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@jordanlewis jordanlewis deleted the jordanlewis:fix-doid-wrapped-array branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.