Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix dist planning of window fns with mutations #37171

Merged
merged 1 commit into from Apr 27, 2019

Conversation

Projects
None yet
3 participants
@jordanlewis
Copy link
Member

commented Apr 26, 2019

Fixes #36830.

Release note (bug fix): permit planning of window functions within
mutation statements (and others that can't be distributed).

@jordanlewis jordanlewis requested review from yuzefovich and RaduBerinde Apr 26, 2019

@jordanlewis jordanlewis requested review from cockroachdb/distsql-prs as code owners Apr 26, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

This change is Reviewable

@RaduBerinde
Copy link
Member

left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @yuzefovich)

@jordanlewis

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Apr 27, 2019

Merge #37171
37171: sql: fix dist planning of window fns with mutations r=jordanlewis a=jordanlewis

Fixes #36830.

Release note (bug fix): permit planning of window functions within
mutation statements (and others that can't be distributed).

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig

This comment has been minimized.

Copy link

commented Apr 27, 2019

Build failed

sql: fix dist planning of window fns with mutations
Release note (bug fix): permit planning of window functions within
mutation statements (and others that can't be distributed).

@jordanlewis jordanlewis force-pushed the jordanlewis:fix-wrapped-window branch from 2d6c51f to 0a347c3 Apr 27, 2019

@jordanlewis

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

bors r+

craig bot pushed a commit that referenced this pull request Apr 27, 2019

Merge #37171
37171: sql: fix dist planning of window fns with mutations r=jordanlewis a=jordanlewis

Fixes #36830.

Release note (bug fix): permit planning of window functions within
mutation statements (and others that can't be distributed).

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig

This comment has been minimized.

Copy link

commented Apr 27, 2019

Build failed

@jordanlewis

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

Lint OOM...

bors r+

craig bot pushed a commit that referenced this pull request Apr 27, 2019

Merge #37171
37171: sql: fix dist planning of window fns with mutations r=jordanlewis a=jordanlewis

Fixes #36830.

Release note (bug fix): permit planning of window functions within
mutation statements (and others that can't be distributed).

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig

This comment has been minimized.

Copy link

commented Apr 27, 2019

Build succeeded

@craig craig bot merged commit 0a347c3 into cockroachdb:master Apr 27, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@jordanlewis jordanlewis deleted the jordanlewis:fix-wrapped-window branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.