Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: support SHOW COLUMNS ... WITH COMMENTS #37174

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
3 participants
@hueypark
Copy link
Contributor

commented Apr 27, 2019

Informs #36439.

Release note (sql change): support SHOW COLUMNS ... WITH COMMENTS
now supports printing out column comments using the optional phrase
WITH COMMENT, e.g SHOW COLUMNS FROM mytable WITH COMMENT.

@hueypark hueypark requested review from cockroachdb/sql-language-prs as code owners Apr 27, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

This change is Reviewable

@jordanlewis jordanlewis requested a review from knz Apr 29, 2019

@jordanlewis

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@hueypark thanks for the contribution and sorry about the delay in review. Could you please rebase this one?

@hueypark

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@jordanlewis Of course, I'll do it before the weekend.

sql: support SHOW COLUMNS ... WITH COMMENTS
Release note (sql change): support SHOW COLUMNS ... WITH COMMENTS
now supports printing out column comments using the optional phrase
`WITH COMMENT`, e.g `SHOW COLUMNS FROM mytable WITH COMMENT`.

@hueypark hueypark force-pushed the hueypark:show-columns-with-comments branch from bea7c10 to d6557e4 May 15, 2019

@jordanlewis

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Thanks!

bors r+

craig bot pushed a commit that referenced this pull request May 21, 2019

Merge #37174
37174: sql: support SHOW COLUMNS ... WITH COMMENTS r=jordanlewis a=hueypark

Informs #36439.

Release note (sql change): support SHOW COLUMNS ... WITH COMMENTS
now supports printing out column comments using the optional phrase
`WITH COMMENT`, e.g `SHOW COLUMNS FROM mytable WITH COMMENT`.

Co-authored-by: Jaewan Park <jaewan.huey.park@gmail.com>
@craig

This comment has been minimized.

Copy link

commented May 21, 2019

Build succeeded

@craig craig bot merged commit d6557e4 into cockroachdb:master May 21, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.