Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: support SHOW DATABASES WITH COMMENTS #37175

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@hueypark
Copy link
Contributor

commented Apr 27, 2019

Informs #36439.

Release note (sql change): support SHOW DATABASES WITH COMMENTS
now supports printing out database comments using the optional phrase
WITH COMMENT, e.g SHOW DATABASES WITH COMMENT.

@hueypark hueypark requested review from cockroachdb/sql-language-prs as code owners Apr 27, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

This change is Reviewable

@jordanlewis jordanlewis requested a review from knz Apr 29, 2019

@jordanlewis
Copy link
Member

left a comment

LGTM, thank you @hueypark!

@jordanlewis

This comment has been minimized.

Copy link
Member

commented May 29, 2019

bors r+

craig bot pushed a commit that referenced this pull request May 29, 2019

Merge #37175
37175: sql: support SHOW DATABASES WITH COMMENTS r=jordanlewis a=hueypark

Informs #36439.

Release note (sql change): support SHOW DATABASES WITH COMMENTS
now supports printing out database comments using the optional phrase
`WITH COMMENT`, e.g `SHOW DATABASES WITH COMMENT`.

Co-authored-by: Jaewan Park <jaewan.huey.park@gmail.com>
@craig

This comment has been minimized.

Copy link

commented May 29, 2019

Build failed

sql: support SHOW DATABASES WITH COMMENTS
Release note (sql change): support SHOW DATABASES WITH COMMENTS
now supports printing out database comments using the optional phrase
`WITH COMMENT`, e.g `SHOW DATABASES WITH COMMENT`.

@hueypark hueypark force-pushed the hueypark:show-databases-with-comments branch from ff00c2b to 7fefd70 May 30, 2019

@hueypark

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

@jordanlewis I fixed the test failure. Please check again.

@jordanlewis

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

bors r+

Thanks again!

craig bot pushed a commit that referenced this pull request Jun 4, 2019

Merge #37175 #37960
37175: sql: support SHOW DATABASES WITH COMMENTS r=jordanlewis a=hueypark

Informs #36439.

Release note (sql change): support SHOW DATABASES WITH COMMENTS
now supports printing out database comments using the optional phrase
`WITH COMMENT`, e.g `SHOW DATABASES WITH COMMENT`.

37960: row: remove unnecessary allocation from cfetcher r=jordanlewis a=jordanlewis

Release note: None

Co-authored-by: Jaewan Park <jaewan.huey.park@gmail.com>
Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig

This comment has been minimized.

Copy link

commented Jun 4, 2019

Build succeeded

@craig craig bot merged commit 7fefd70 into cockroachdb:master Jun 4, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.