Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: add now() -> date implementation #37284

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
3 participants
@mjibson
Copy link
Member

commented May 3, 2019

Resolving a small irritation for date columns that want a default value
of now.

Closes #37260

Release note (sql change): add an overload for now() that returns a
date.

builtins: add now() -> date implementation
Resolving a small irritation for date columns that want a default value
of now.

Release note (sql change): add an overload for now() that returns a
date.

@mjibson mjibson requested a review from jordanlewis May 3, 2019

@mjibson mjibson requested a review from cockroachdb/sql-rest-prs as a code owner May 3, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented May 3, 2019

This change is Reviewable

@mjibson

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

@jordanlewis This is an updated version of #37260 that correctly includes the session time zone for now():::DATE.

@jordanlewis

This comment has been minimized.

Copy link
Member

commented May 3, 2019

LGTM - thanks!

@mjibson

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

bors r+

craig bot pushed a commit that referenced this pull request May 3, 2019

Merge #37284
37284: builtins: add now() -> date implementation r=mjibson a=mjibson

Resolving a small irritation for date columns that want a default value
of now.

Closes #37260

Release note (sql change): add an overload for now() that returns a
date.

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig

This comment has been minimized.

Copy link

commented May 3, 2019

Build succeeded

@craig craig bot merged commit 18c3da4 into cockroachdb:master May 3, 2019

4 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
security/snyk - pkg/ui/package.json (Cockroach Labs) No manifest changes detected

@mjibson mjibson deleted the mjibson:now branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.