Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: support empty default_tablespace for compat #37333

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
5 participants
@jordanlewis
Copy link
Member

commented May 6, 2019

Closes #26409

Release note (sql change): support the empty default_tablespace session
variable for pg compatibility

@jordanlewis jordanlewis requested review from mjibson and knz May 6, 2019

@jordanlewis jordanlewis requested review from cockroachdb/sql-execution-prs as code owners May 6, 2019

@CLAassistant

This comment has been minimized.

Copy link

commented May 6, 2019

CLA assistant check
All committers have signed the CLA.

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented May 6, 2019

This change is Reviewable

@jordanlewis jordanlewis force-pushed the jordanlewis:default-tablespace branch from 1c6e1cc to 8d5faf5 May 6, 2019

@mjibson

mjibson approved these changes May 6, 2019

sql: support empty default_tablespace for compat
Release note (sql change): support the empty default_tablespace session
variable for pg compatibility

@jordanlewis jordanlewis force-pushed the jordanlewis:default-tablespace branch from 8d5faf5 to 381a6ef May 6, 2019

@jordanlewis

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

bors r+

craig bot pushed a commit that referenced this pull request May 6, 2019

Merge #37333
37333: sql: support empty default_tablespace for compat r=jordanlewis a=jordanlewis

Closes #26409

Release note (sql change): support the empty default_tablespace session
variable for pg compatibility

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig

This comment has been minimized.

Copy link

commented May 6, 2019

Build succeeded

@craig craig bot merged commit 381a6ef into cockroachdb:master May 6, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@knz
Copy link
Member

left a comment

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@jordanlewis jordanlewis deleted the jordanlewis:default-tablespace branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.