Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: support casting empty arrays to array types #37356

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
3 participants
@jordanlewis
Copy link
Member

commented May 7, 2019

Previously, empty arrays couldn't be cast to array types - you'd have to
use the type annotation syntax.

Now, this limitation is lifted.

Closes #18420.

Release note (sql change): permit casting empty arrays to any array
type.

tree: support casting empty arrays to array types
Previously, empty arrays couldn't be cast to array types - you'd have to
use the type annotation syntax.

Now, this limitation is lifted.

Release note (sql change): permit casting empty arrays to any array
type.

@jordanlewis jordanlewis requested review from mjibson and knz May 7, 2019

@jordanlewis jordanlewis requested a review from cockroachdb/sql-rest-prs as a code owner May 7, 2019

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

commented May 7, 2019

This change is Reviewable

@knz

knz approved these changes May 7, 2019

Copy link
Member

left a comment

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mjibson)

@jordanlewis

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

bors r+

craig bot pushed a commit that referenced this pull request May 7, 2019

Merge #37356
37356: tree: support casting empty arrays to array types r=jordanlewis a=jordanlewis

Previously, empty arrays couldn't be cast to array types - you'd have to
use the type annotation syntax.

Now, this limitation is lifted.

Closes #18420.

Release note (sql change): permit casting empty arrays to any array
type.

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig

This comment has been minimized.

Copy link

commented May 7, 2019

Build succeeded

@craig craig bot merged commit d6970a0 into cockroachdb:master May 7, 2019

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@jordanlewis jordanlewis deleted the jordanlewis:empty-array-cast branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.